Skip to content

fix: handle ical.js group parameter form to prevent custom label corruption on save/re-fetch cycle#5378

Open
pallavibakale wants to merge 6 commits into
nextcloud:mainfrom
pallavibakale:fix/custom-label-for-contact-details-5302
Open

fix: handle ical.js group parameter form to prevent custom label corruption on save/re-fetch cycle#5378
pallavibakale wants to merge 6 commits into
nextcloud:mainfrom
pallavibakale:fix/custom-label-for-contact-details-5302

Conversation

@pallavibakale

@pallavibakale pallavibakale commented Jun 9, 2026

Copy link
Copy Markdown
  • Fix custom label (X-ABLABEL) handling to correctly work with properties loaded from the server
  • Prevent prefix corruption (e.g NEXTCLOUD1.TEL) when re-applying a custom label after a save/fetch cycle
  • Fix propGroup and propLabel to detect the group parameter form that ical.js uses after parsing from server
image

Fixes: #5302

@hamza221 hamza221 added 2. developing Work in progress skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Jun 11, 2026
hamza221
hamza221 requested changes Jun 11, 2026
View reviewed changes

@hamza221 hamza221 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thank you for opening this PR,
The diff is really big and it looks like it's mostly spacing related fixes.
Can you please run npm ci then npm run lint:fix then push again

@codecov

codecov Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...mponents/ContactDetails/ContactDetailsProperty.vue 0.00% 17 Missing ⚠️
src/mixins/PropertyMixin.js 0.00% 11 Missing and 6 partials ⚠️

📢 Thoughts on this report? Let us know!

@pallavibakale
fix: handle ical.js group parameter form to prevent custom label corr…
b8d2f00 
…uption on save/re-fetch cycle

Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
@pallavibakale pallavibakale force-pushed the fix/custom-label-for-contact-details-5302 branch from c71d75f to ccbed23 Compare June 11, 2026 15:26
@pallavibakale

pallavibakale commented Jun 11, 2026

Copy link
Copy Markdown
Author

Hello, Thank you for opening this PR, The diff is really big and it looks like it's mostly spacing related fixes. Can you please run npm ci then npm run lint:fix then push again

Hello Hamza, I have fixed the linting issues, the PR looks cleaner than before.
The DCO also failed, I ran the below to fix the issue:

git rebase HEAD~5 --signoff  
git push --force-with-lease origin fix/custom-label-for-contact-details-5302

Will do the same for the other PR as well.

@pallavibakale pallavibakale requested a review from hamza221 June 14, 2026 15:52
@DerDreschner DerDreschner added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 15, 2026
@pallavibakale pallavibakale force-pushed the fix/custom-label-for-contact-details-5302 branch from ccbed23 to 9613346 Compare June 15, 2026 15:11
@pallavibakale
fix: linting fixes
0efc4d7 
Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
@pallavibakale
fix: linting fixes
7436924 
Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
@pallavibakale
fix: fixed linting issues
ad58efe 
Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
@pallavibakale
fix: resolve linting issues
9ec8c19 
Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
@pallavibakale pallavibakale force-pushed the fix/custom-label-for-contact-details-5302 branch from 9613346 to 9ec8c19 Compare June 18, 2026 15:47
@pallavibakale
fix: linting issues
175ad8b 
Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews feedback-requested skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom email/phone labels not working

3 participants

@pallavibakale @hamza221 @DerDreschner